Skip to content

<fix>[storage]: ZSTAC-81222 defer referenced reimage trash - #4675

Open
ZStack-Robot wants to merge 1 commit into
5.5.38from
sync/haidong.pang/fix/ZSTAC-81222-no-trash
Open

<fix>[storage]: ZSTAC-81222 defer referenced reimage trash#4675
ZStack-Robot wants to merge 1 commit into
5.5.38from
sync/haidong.pang/fix/ZSTAC-81222-no-trash

Conversation

@ZStack-Robot

@ZStack-Robot ZStack-Robot commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Keep the old root volume out of trash while linked-clone children still depend on its snapshot chain. Transfer cleanup ownership to the existing trash/GC path after the last reference is removed.

Changes

  • Skip ReimageVolume trash creation while downstream references exist.
  • Create a delayed zero-size trash marker after the last reference is removed.
  • Reuse existing trash GC to delete the old backing chain and synchronize capacity.

Testing

  • mvn -pl storage -am -Dmaven.test.skip=true compile
  • Groovy regression test
  • Real ZBS lifecycle validation
  • CI pipeline

Resolves: ZSTAC-81222

sync from gitlab !10704

haidong.pang
<fix>[storage]: reclaim referenced reimage chains
9b64b75 
Keep an old root out of reimage trash while downstream snapshot references still depend on it.

Persist reference cleanup, protect remaining leaves at execution time, and retry external primary storage deletion from leaf to root using only the undeleted suffix. Sync capacity and remove matching legacy reimage trash after cleanup.

Resolves: ZSTAC-81222

Change-Id: I500146d6898405f4df0cc18a1d8a4aaa94fee49d
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 57eb81f3-1efb-48bb-b16e-c300b03c09e5

📥 Commits

Reviewing files that changed from the base of the PR and between 8948841 and 9b64b75.

📒 Files selected for processing (7)
  • header/src/main/java/org/zstack/header/storage/snapshot/reference/VolumeSnapshotReferenceTreeVO_.java
  • storage/src/main/java/org/zstack/storage/addon/primary/ExternalDeleteVolumeChainGC.java
  • storage/src/main/java/org/zstack/storage/addon/primary/ExternalPrimaryStorage.java
  • storage/src/main/java/org/zstack/storage/snapshot/reference/DeleteVolumeSnapshotReferenceGC.java
  • storage/src/main/java/org/zstack/storage/snapshot/reference/VolumeSnapshotReferenceTreeBase.java
  • storage/src/main/java/org/zstack/storage/snapshot/reference/VolumeSnapshotReferenceUtils.java
  • test/src/test/groovy/org/zstack/test/integration/storage/primary/addon/zbs/ZbsPrimaryStorageCase.groovy

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ZStack-Robot